Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bot: when a generic bot failure occurs also report it in phabricator. #986

Merged
merged 2 commits into from
Sep 23, 2021
Merged

bot: when a generic bot failure occurs also report it in phabricator. #986

merged 2 commits into from
Sep 23, 2021

Conversation

abpostelnicu
Copy link
Collaborator

@abpostelnicu abpostelnicu commented Sep 23, 2021 •
edited
Loading

We are using requests in the backend module, so track the requests.exceptions.HTTPError and update phabricator.
This fixes #984.

@abpostelnicu abpostelnicu self-assigned this Sep 23, 2021
marco-c
marco-c reviewed Sep 23, 2021
View reviewed changes
bot/code_review_bot/cli.py Outdated Show resolved Hide resolved
@abpostelnicu abpostelnicu changed the title bot: treat Http exception in a separate way. bot: when a generic bot failure occurs also report it in phabricator. Sep 23, 2021
@abpostelnicu abpostelnicu marked this pull request as ready for review September 23, 2021 12:08
marco-c
marco-c reviewed Sep 23, 2021
View reviewed changes
bot/code_review_bot/cli.py Outdated Show resolved Hide resolved
marco-c
marco-c reviewed Sep 23, 2021
View reviewed changes
bot/code_review_bot/cli.py Outdated Show resolved Hide resolved
@abpostelnicu abpostelnicu merged commit 9df3342 into mozilla:master Sep 23, 2021
@abpostelnicu abpostelnicu deleted the dev branch September 23, 2021 15:14
@marco-c marco-c mentioned this pull request Oct 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-c marco-c marco-c approved these changes

Assignees

@abpostelnicu abpostelnicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When failing during workflow.run, post a generic failure like we do during events
2 participants
@abpostelnicu @marco-c